Skip to content

Conversation

rustagir
Copy link
Contributor

@rustagir rustagir commented Jun 3, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-48887

Staging Links

  • interact-data/atlas-search-tutorial
  • data-modeling/indexes
  • interact-data
  • quick-start-rails/next-steps
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?
    • Are the page titles greater than 20 characters long and SEO relevant?

    Copy link

    netlify bot commented Jun 3, 2025

    Deploy Preview for docs-mongoid ready!

    Name Link
    🔨 Latest commit 4e429a8
    🔍 Latest deploy log https://app.netlify.com/projects/docs-mongoid/deploys/6840606a2fd8ac0008acd8fe
    😎 Deploy Preview https://deploy-preview-129--docs-mongoid.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify project configuration.

    Copy link
    Contributor

    @norareidy norareidy left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM with some suggestions

    Comment on lines 65 to 66
    To successfully demonstrate the search functionality later in
    the tutorial, insert sample documents that contain some overlapping
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    S: this wording seems a little clearer to me since the tutorial is demostrating:

    Suggested change
    To successfully demonstrate the search functionality later in
    the tutorial, insert sample documents that contain some overlapping
    To achieve the search functionality demonstrated later in
    the tutorial, insert sample documents that contain some overlapping


    git clone https://github.com/mongodb-developer/mongodb-atlas-with-ruby-on-rails-example.git

    Then, set up the following components:
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    S: since each list item is more of an action rather than a component:

    Suggested change
    Then, set up the following components:
    Then, perform the following setup actions:

    Comment on lines 82 to 83
    First, update the ``Idea`` model to handle queries to our
    database by defining the ``search`` method in the model. The
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    S:

    Suggested change
    First, update the ``Idea`` model to handle queries to our
    database by defining the ``search`` method in the model. The
    First, update the ``Idea`` model to handle database queries
    by defining the ``search`` method in the model. The

    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    reworded

    Comment on lines 168 to 172
    In this step, you create a ``SearchesController`` to handle Atlas Search
    requests and display results.

    Run the following command to generate the ``SearchesController``
    and the ``display_results`` view file:
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    S: I don't think you need the step intro sentence

    Suggested change
    In this step, you create a ``SearchesController`` to handle Atlas Search
    requests and display results.
    Run the following command to generate the ``SearchesController``
    and the ``display_results`` view file:
    Run the following command to generate the ``SearchesController``
    and the ``display_results`` view file, which handle Atlas Search requests and display the results:


    .. step:: Start your application and run Search queries.

    Run the following command to start your application:
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    S:

    Suggested change
    Run the following command to start your application:
    In your project directory, run the following command to start your application:

    @rustagir rustagir merged commit 64ddba9 into mongodb:master Jun 4, 2025
    5 of 6 checks passed
    rustagir added a commit that referenced this pull request Jun 4, 2025
    * DOCSP-48887: docs+ atlas search tutorial
    
    * small fix
    
    * vale
    
    * tip
    
    * NR PR fixes 1
    
    * wip
    
    (cherry picked from commit 64ddba9)
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants